Skip to content

Refactor: replace use of SpanAttributes in test-instrumentation-aiohttp-client #3502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

caterinaandreu
Copy link
Contributor

Description

Replaces usage of SpanAttributes with opentelemetry.semconv._incubating.attributes in instrumentation/opentelemetry-instrumentation-aiohttp-client

Refs: #3475

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tox

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Copy link

linux-foundation-easycla bot commented May 15, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: xrmx / name: Riccardo Magliocchetti (f6641dd)
  • ✅ login: caterinaandreu / name: Caterina Andreu (242bf9b)

@xrmx xrmx enabled auto-merge (squash) May 15, 2025 17:55
@xrmx xrmx mentioned this pull request May 15, 2025
41 tasks
@xrmx xrmx merged commit 3efd161 into open-telemetry:main May 15, 2025
719 of 720 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants