Report isolation level on ActiveRecord transaction #1672
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirs
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle,
xuan-cao-swi and
a team
as code owners
| tracer.in_span('ActiveRecord.transaction', attributes: { 'code.namespace' => name }) do | ||
| super | ||
| def transaction(*args, **kwargs, &block) | ||
| attributes = { 'code.namespace' => name } |
There was a problem hiding this comment.
nit:
attributes = {
'code.namespace' => name,
'db.transaction_isolation' => kwargs[:isolation]
}.compact!
There was a problem hiding this comment.
@xuan-cao-swi this would potentially set the attributes hash to nil.
https://ruby-doc.org/3.4.1/Hash.html#method-i-compact-21
compact! → self or nil
Returns self with all its nil-valued entries removed (in place):
Returns nil if no entries were removed.
| attributes['db.transaction_isolation'] = kwargs[:isolation].to_s | ||
| end | ||
| tracer.in_span('ActiveRecord.transaction', attributes: attributes) do | ||
| super(*args, **kwargs, &block) |
robertlaurin
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very useful field if your app is in progress of switching in between isolation levels.