chore: relax inst all version constraints #1695
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlaurin
requested review from
fbogsany,
mwear,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle,
xuan-cao-swi and
a team
as code owners
| spec.add_dependency 'opentelemetry-instrumentation-sidekiq', '~> 0.26.0' | ||
| spec.add_dependency 'opentelemetry-instrumentation-sinatra', '~> 0.26.0' | ||
| spec.add_dependency 'opentelemetry-instrumentation-trilogy', '~> 0.61.0' | ||
| spec.add_dependency 'opentelemetry-instrumentation-active_model_serializers', '~> 0.22' |
There was a problem hiding this comment.
Please update the README explaining the implications of this change.
Warn users that they may receive unexpected updates of breaking changes from transitive dependencies and they should pin gem versions to avoid that.
Alternatively we can explore a "all-in-one" gem that includes all of the source code in a single gem instead of relying on gem dependencies or add scripts/actions to bump the all gem when a minor version bump of the instrumentations are released.
That would make it possible to release individual gems and simplify the release process a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow anyone using instrumentation all to take the latest minor version without having to wait for a release of instrumentation all.