Skip to content

Make Configurator and Config SDK features optional #4648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
+27 −9
Closed

Make Configurator and Config SDK features optional #4648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ddf5596
Configurator support is optional
pellared Sep 5, 2025
7184efe
add changelog entries
pellared Sep 5, 2025
f26e5cc
remove trailing spaces
pellared Sep 5, 2025
ff3d454
Merge branch 'main' into issue-4644
pellared Sep 8, 2025
240a4bc
Merge branch 'main' into issue-4644
pellared Sep 8, 2025
7ee6af7
Merge branch 'main' into issue-4644
pellared Sep 11, 2025
f113adc
Config support is optional
pellared Sep 11, 2025
d03d3d6
Merge branch 'main' into issue-4644
pellared Sep 16, 2025
cd6513b
Merge branch 'main' into issue-4644
pellared Sep 24, 2025
7885186
Merge branch 'main' into issue-4644
pellared Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,27 @@ release.

### Traces

- Restore `TraceIdRatioBased` and give it a deprecation timeline. Update recommended
warnings based on feedback in issue [#4601](https://github.com/open-telemetry/opentelemetry-specification/issues/4601).
([#4627](https://github.com/open-telemetry/opentelemetry-specification/pull/4627))
- Changes of `TracerConfig.disabled` MUST be eventually visible.
([#4645](https://github.com/open-telemetry/opentelemetry-specification/pull/4645))
- `TracerConfigurator` and `TracerConfig` are now optional (it MAY be supported by the SDK).
([#4648](https://github.com/open-telemetry/opentelemetry-specification/pull/4648))

### Metrics

- Changes of `MeterConfig.disabled` MUST be eventually visible.
([#4645](https://github.com/open-telemetry/opentelemetry-specification/pull/4645))
- `MeterConfigurator` and `MeterConfig` are now optional (it MAY be supported by the SDK).
([#4648](https://github.com/open-telemetry/opentelemetry-specification/pull/4648))

### Logs

- Restore `TraceIdRatioBased` and give it a deprecation timeline. Update recommended
warnings based on feedback in issue [#4601](https://github.com/open-telemetry/opentelemetry-specification/issues/4601).
([#4627](https://github.com/open-telemetry/opentelemetry-specification/pull/4627))
- Changes of `LoggerConfig.disabled` MUST be eventually visible.
([#4645](https://github.com/open-telemetry/opentelemetry-specification/pull/4645))
- `LoggerConfigurator` and `LoggerConfig` are now optional (it MAY be supported by the SDK).
([#4648](https://github.com/open-telemetry/opentelemetry-specification/pull/4648))

### Baggage

Expand Down
8 changes: 6 additions & 2 deletions specification/logs/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ working `Logger` MUST be returned as a fallback rather than returning null or
throwing an exception, its `name` SHOULD keep the original invalid value, and a
message reporting that the specified value is invalid SHOULD be logged.

**Status**: [Development](../document-status.md) - The `LoggerProvider` MUST
compute the relevant [LoggerConfig](#loggerconfig) using the
**Status**: [Development](../document-status.md) - The `LoggerProvider` SHOULD
compute the relevant [LoggerConfig](#loggerconfig) using a
configured [LoggerConfigurator](#loggerconfigurator), and create
a `Logger` whose behavior conforms to that `LoggerConfig`.

Expand All @@ -103,6 +103,8 @@ configuration only via this reference.

**Status**: [Development](../document-status.md)

The `LoggerConfigurator` MAY be supported by the SDK.

A `LoggerConfigurator` is a function which computes
the [LoggerConfig](#loggerconfig) for a [Logger](#logger).

Expand Down Expand Up @@ -183,6 +185,8 @@ the `Logger` MUST be updated to behave according to the new `LoggerConfig`.

**Status**: [Development](../document-status.md)

The `LoggerConfig` MAY be supported by the SDK.

A `LoggerConfig` defines various configurable aspects of a `Logger`'s behavior.
It consists of the following parameters:

Expand Down
8 changes: 6 additions & 2 deletions specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@ working Meter MUST be returned as a fallback rather than returning null or
throwing an exception, its `name` SHOULD keep the original invalid value, and a
message reporting that the specified value is invalid SHOULD be logged.

**Status**: [Development](../document-status.md) - The `MeterProvider` MUST
compute the relevant [MeterConfig](#meterconfig) using the
**Status**: [Development](../document-status.md) - The `MeterProvider` SHOULD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use some other terminology to require that MeterProvider will interact with file configuration, in the case it isn't using MeterConfigurator?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For OTel Go it is this is the other way. File configuration module is bootstrapping the MeterProvider (et al). More: https://pkg.go.dev/go.opentelemetry.io/contrib/otelconf@v0.17.0/v0.3.0#NewSDK

compute the relevant [MeterConfig](#meterconfig) using a
configured [MeterConfigurator](#meterconfigurator), and create
a `Meter` whose behavior conforms to that `MeterConfig`.

Expand All @@ -156,6 +156,8 @@ configuration only via this reference.

**Status**: [Development](../document-status.md)

The `MeterConfigurator` MAY be supported by the SDK.

A `MeterConfigurator` is a function which computes
the [MeterConfig](#meterconfig) for a [Meter](#meter).

Expand Down Expand Up @@ -857,6 +859,8 @@ the `Meter` MUST be updated to behave according to the new `MeterConfig`.

**Status**: [Development](../document-status.md)

The `MeterConfig` MAY be supported by the SDK.

A `MeterConfig` defines various configurable aspects of a `Meter`'s behavior.
It consists of the following parameters:

Expand Down
8 changes: 6 additions & 2 deletions specification/trace/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ The input provided by the user MUST be used to create
an [`InstrumentationScope`](../common/instrumentation-scope.md) instance which
is stored on the created `Tracer`.

**Status**: [Development](../document-status.md) - The `TracerProvider` MUST
compute the relevant [TracerConfig](#tracerconfig) using the
**Status**: [Development](../document-status.md) - The `TracerProvider` SHOULD
compute the relevant [TracerConfig](#tracerconfig) using a
configured [TracerConfigurator](#tracerconfigurator), and create
a `Tracer` whose behavior conforms to that `TracerConfig`.

Expand All @@ -125,6 +125,8 @@ reference.

**Status**: [Development](../document-status.md)

The `TracerConfigurator` MAY be supported by the SDK.

A `TracerConfigurator` is a function which computes
the [TracerConfig](#tracerconfig) for a [Tracer](#tracer).

Expand Down Expand Up @@ -196,6 +198,8 @@ the `Tracer` MUST be updated to behave according to the new `TracerConfig`.

**Status**: [Development](../document-status.md)

The `TracerConfig` MAY be supported by the SDK.

A `TracerConfig` defines various configurable aspects of a `Tracer`'s behavior.
It consists of the following parameters:

Expand Down
Loading