-
Notifications
You must be signed in to change notification settings - Fork 931
Extend the set of attribute value types #4651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pellared
wants to merge
87
commits into
open-telemetry:main
Choose a base branch
from
pellared:extend-attrs-dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit c17aec6.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tsloughter
reviewed
Oct 6, 2025
pellared
commented
Oct 6, 2025
This was referenced Oct 8, 2025
Open
lmolkova
approved these changes
Oct 14, 2025
trask
reviewed
Oct 14, 2025
pellared
commented
Oct 14, 2025
dyladan
reviewed
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:api
Cross language API specification issue
area:data-model
For issues related to data model
area:sdk
Related to the SDK
enhancement
New feature or request
entities
spec:logs
Related to the specification/logs directory
spec:metrics
Related to the specification/metrics directory
spec:resource
Related to the specification/resource directory
spec:trace
Related to the specification/trace directory
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
AnyValue
type supporting complex data structures (empty value, byte arrays, heterogeneous arrays and maps).AnyValue
type.Extend attribute types
Prior-art (this PR guides towards this): #4636
Prototype: open-telemetry/opentelemetry-go#6809
Follows #4614
Related to #4602
Related proto PR: open-telemetry/opentelemetry-proto#707
https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/4485-extending-attributes-to-support-complex-values.md#how describes how languages should add support for new attribute value types.
Closes #4460 (no longer needed - feature is removed)
OTEP changes
Notice that this PR has changed the strategy for https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/4485-extending-attributes-to-support-complex-values.md#api from:
to simply:
This is the agreement up to this point: #4651 (comment)
The other change in the OTEP is because of #4651 (comment).
Attribute limit updates
Towards #4487
This also proposes minimal and non-breaking additions for the attribute limits: https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/4485-extending-attributes-to-support-complex-values.md#attribute-limits.
The proposal for attribute count limit is proposed because of #4651 (comment).
The proposal for attribute value length limit seems the most logical to me.
Comments to be addressed as followups
I am going to create issues to be created after this is PR merged: