-
Notifications
You must be signed in to change notification settings - Fork 931
[spec/profiles] initial commit #4685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
florianl
wants to merge
11
commits into
open-telemetry:main
Choose a base branch
from
florianl:profiles-start
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+93
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
This was referenced Oct 10, 2025
svrnm
reviewed
Oct 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit, overall LGTM
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
tigrannajaryan
approved these changes
Oct 14, 2025
reyang
reviewed
Oct 14, 2025
felixge
approved these changes
Oct 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @florianl 🙇
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
99a9509
to
93ccadc
Compare
reyang
reviewed
Oct 15, 2025
reyang
reviewed
Oct 15, 2025
reyang
approved these changes
Oct 15, 2025
LGTM assuming changelog will be updated. |
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Updated with 18d133b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Start to document OTel Profiles.
Friendly ping @open-telemetry/profiling-approvers.
For non-trivial changes, follow the change proposal process.
CHANGELOG.md
file updated for non-trivial changes