This repository was archived by the owner on Oct 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 384
setMaxResolution for adaptive video #699
Open
thegobot
wants to merge
20
commits into
open-webrtc-toolkit:master
Choose a base branch
from
thegobot:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
3e1d895
Update AVStreamOut.cpp
thegobot 4ada3ee
Merge branch 'master' into master
thegobot 81b9752
Add files via upload
thegobot dc1aae1
Add files via upload
thegobot 1d30eda
Delete bad_7sec_10mb.mp4
thegobot 771fbf5
Add files via upload
thegobot a7cfc1b
Update daemon-bin.sh
thegobot aadc9b7
Update libapi.js
thegobot 2cb8475
Update VideoTranscoderWrapper.h
thegobot f70e875
Update VideoTranscoderWrapper.cpp
thegobot 61a5b90
Update VideoFrameTranscoder.h
thegobot d95da51
Update VideoFrameTranscoderImpl.h
thegobot 35cadbb
Update VideoTranscoder.cpp
thegobot 387b6e5
Update VideoTranscoder.h
thegobot f837022
Update MediaFramePipeline.h
thegobot 7f77a26
Update VCMFrameEncoder.cpp
thegobot ef659cc
Update LICENSE
thegobot bf915c7
Update README.md
thegobot f762ad7
Update README.md
thegobot b247d77
Update README.md
thegobot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
Apache License | ||
Apache License!!! | ||
Version 2.0, January 2004 | ||
http://www.apache.org/licenses/ | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -176,6 +176,26 @@ void VideoTranscoder::forceKeyFrame(const v8::FunctionCallbackInfo<v8::Value>& a | |
me->forceKeyFrame(outStreamID); | ||
} | ||
|
||
void VideoTranscoder::setMaxResolution(const v8::FunctionCallbackInfo<v8::Value>& args){ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This function is not registered in node layer through "init" function in line 24. Who will call this function? |
||
|
||
Isolate* isolate = Isolate::GetCurrent(); | ||
HandleScope scope(isolate); | ||
|
||
VideoTranscoder* obj = ObjectWrap::Unwrap<VideoTranscoder>(args.Holder()); | ||
mcu::VideoTranscoder* me = obj->me; | ||
|
||
String::Utf8Value param0(args[0]->ToString()); | ||
String::Utf8Value param1(args[1]->ToString()); | ||
String::Utf8Value param2(args[2]->ToString()); | ||
|
||
std::string outStreamID = std::string(*param0); | ||
int width = std::stoi(std::string(*param1)); | ||
int height = std::stoi(std::string(*param2)); | ||
|
||
me->setMaxResolution(outStreamID, width, height); | ||
} | ||
|
||
|
||
#ifndef BUILD_FOR_ANALYTICS | ||
void VideoTranscoder::drawText(const v8::FunctionCallbackInfo<v8::Value>& args) { | ||
Isolate* isolate = Isolate::GetCurrent(); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -93,7 +93,7 @@ function calculateSignature (toSign, key) { | |
function ManagementApi (spec) { | ||
this.id = spec.id; | ||
this.key = spec.key; | ||
this.url = spec.url || '/'; | ||
this.url = spec.url || window.location.pathname.replace(/\/console.*/g, "/"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. code conflict with latest master code |
||
this.send = function (method, body, url, callback) { // callback (err, resp) | ||
var service = this.id; | ||
var key = this.key; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why adding this change to license and readme file?