Show background stream error message #2451
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+284
to
+287
| } => { | ||
| let env = std::env::var("MANUALLY_DEBUG_TUI_BACKGROUND_RETRY") | ||
| .unwrap_or_default(); | ||
| if env == "1" { |
There was a problem hiding this comment.
Suggested change
| } => { | |
| let env = std::env::var("MANUALLY_DEBUG_TUI_BACKGROUND_RETRY") | |
| .unwrap_or_default(); | |
| if env == "1" { | |
| } if std::env::var("MANUALLY_DEBUG_TUI_BACKGROUND_RETRY").is_ok_and(|v| v == "1") => { | |
| // ... |
then you don't have to repeat the dispatch_key_event logic.
codex-rs/tui/src/history_cell.rs
Outdated
Comment on lines
643
to
650
| let lines: Vec<Line<'static>> = vec![ | ||
| Line::from(vec![ | ||
| "ℹ".magenta(), | ||
| " ".into(), | ||
| Span::styled(message, Style::default().add_modifier(Modifier::DIM)), | ||
| ]), | ||
| Line::from(""), | ||
| ]; |
There was a problem hiding this comment.
i believe we removed these because we emit these whenever there's an otherwise unhandled event, which looks weird when these get added for other features that the tui doesn't handle yet. PatchApplyEnd used to be one of these though i'm not sure it still is.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to at least tell the user when we got an error. I've never seen it actually recover from the background stream error, so IMO the next step is probably to just cancel the turn until we fix that. Will do it as a second PR if people agree.