Skip to content

Conversation

alexjustesen
Copy link
Collaborator

@alexjustesen alexjustesen commented Apr 10, 2025

📃 Description

This PR adds validation to the brewery sorting to check for valid fields and sort direction.

✅ To-dos

  • write tests

🪵 Changelog

➕ Added

  • BrewerySort rule to v1/breweries endpoint

@alexjustesen alexjustesen added the 🐛 bug Something isn't working label Apr 10, 2025
@alexjustesen alexjustesen self-assigned this Apr 10, 2025
@alexjustesen alexjustesen requested a review from chrisjm as a code owner April 10, 2025 11:37
@alexjustesen alexjustesen marked this pull request as draft April 10, 2025 11:40
@chrisjm
Copy link
Collaborator

chrisjm commented Apr 10, 2025

Looks good! And yes to tests 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InvalidArgumentException: Order direction must be "asc" or "desc".
2 participants