-
-
Notifications
You must be signed in to change notification settings - Fork 8
Update nwp-consumer container tag to 1.1.32 #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By doing the class parameters like this you're losing any kind of hinting you might get from your IDE on what the ContainerDefinition class is expecting, which will increase the likelihood of erroneus entries. I'm not sure it's necessarily a better or clearer way of assigning the containers.
Either way, don't forget to run uv run ruff format src/airflow_dags/dags/india/consume-nwp-dag.py
to fix up the spacing in those dicts.
Ill do the formatting, Should i just do two different containers? |
I guess in this case it depends what the more useful information for a developer reading this is: either, what each container's environment individually is (in which case do two containers), or how the containers' environments differ (in which case keep as is). It's probably only really me and you looking at this, so happy to go with you if you reckon parsing their differences more quickly is of greater value. It's not super important! |
Thanks, ill keep it as it is at the moment. Two containers looked a bit too much like duplicate code |
Pull Request
Description
How Has This Been Tested?
Checklist: