Skip to content

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Sep 1, 2025

Pull Request

Description

  • India NWP consumer up to 1.1.32, this is needed for metoffice change
  • ECWMF: Increase memory and CPU for ECWMF consumer
  • GFS: Add higher tolerence for nans,

How Has This Been Tested?

  • manually put in on dev overnight

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield changed the title Update nwp-consumer container tag to 1.1.30 Update nwp-consumer container tag to 1.1.3X Sep 5, 2025
@peterdudfield peterdudfield changed the title Update nwp-consumer container tag to 1.1.3X Update nwp-consumer container tag to 1.1.32 Sep 15, 2025
@peterdudfield peterdudfield marked this pull request as ready for review September 15, 2025 17:57
Copy link
Contributor

@devsjc devsjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By doing the class parameters like this you're losing any kind of hinting you might get from your IDE on what the ContainerDefinition class is expecting, which will increase the likelihood of erroneus entries. I'm not sure it's necessarily a better or clearer way of assigning the containers.

Either way, don't forget to run uv run ruff format src/airflow_dags/dags/india/consume-nwp-dag.py to fix up the spacing in those dicts.

@peterdudfield
Copy link
Contributor Author

uv run ruff format src/airflow_dags/dags/india/consume-nwp-dag.py

Ill do the formatting,

Should i just do two different containers?

@devsjc
Copy link
Contributor

devsjc commented Sep 16, 2025

I guess in this case it depends what the more useful information for a developer reading this is: either, what each container's environment individually is (in which case do two containers), or how the containers' environments differ (in which case keep as is). It's probably only really me and you looking at this, so happy to go with you if you reckon parsing their differences more quickly is of greater value. It's not super important!

@peterdudfield peterdudfield merged commit b380c6b into main Sep 16, 2025
4 checks passed
@peterdudfield peterdudfield deleted the india-nwp-1.1.30 branch September 16, 2025 09:10
@peterdudfield
Copy link
Contributor Author

I guess in this case it depends what the more useful information for a developer reading this is: either, what each container's environment individually is (in which case do two containers), or how the containers' environments differ (in which case keep as is). It's probably only really me and you looking at this, so happy to go with you if you reckon parsing their differences more quickly is of greater value. It's not super important!

Thanks, ill keep it as it is at the moment. Two containers looked a bit too much like duplicate code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants