Skip to content

Fix XMP write and discarded return value. #27506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged

Conversation

vrabaud
Copy link
Contributor

@vrabaud vrabaud commented Jul 2, 2025

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Contributor

cc @vpisarev

@vrabaud
Copy link
Contributor Author

vrabaud commented Jul 3, 2025

This patch matters for 4.12.1 (if any). Otherwise, this code does not compile with no_discard (C++17) and a recent libavif.

@vpisarev vpisarev self-requested a review July 9, 2025 09:45
@vpisarev
Copy link
Contributor

vpisarev commented Jul 9, 2025

@asmorkalov, I think, it should be merged, the sooner the better

@asmorkalov asmorkalov self-assigned this Jul 14, 2025
@asmorkalov asmorkalov merged commit 0a1a07d into opencv:4.x Jul 14, 2025
27 of 28 checks passed
@asmorkalov asmorkalov mentioned this pull request Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants