fix: Fixes expandAll button functionality #1312
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbrandes
requested changes
Mar 4, 2024
| title={sectionTitle} | ||
| open={open} | ||
| onToggle={() => { setOpen(!open); }} | ||
| onToggle={() => { setOpen(!open); setExpandedSections((prevObj) => ({ ...prevObj, [section.id]: !open })); }} |
There was a problem hiding this comment.
I feel like at this point the on event is getting verbose enough that a proper handling function would be better. There's also a lot in common with the next two changes, so it's probably going to be worth it for DRYness.
|
Since this changes user-facing behavior, we'll need product confirmation on whether it's actually a bug or not. (If it's a bug you don't necessarily need to go through the Product Review Process. @jmakowski1123, what's your take? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On collapsing all the sections, the button now automatically show 'Expand All'. Similar in case of vice versa. Fixes #1311
Before:
After:
