Skip to content

Brings ofxCv into the core #4861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 466 commits into
base: master
Choose a base branch
from
Open

Brings ofxCv into the core #4861

wants to merge 466 commits into from

Conversation

arturoc
Copy link
Member

@arturoc arturoc commented Feb 19, 2016

Still needs some work.

  • openCv libraries should go out once we remove the binaries from the core and are built through apothecary
  • ofxOpenCv addon_config.mk should be now ofxCv's and ofxOpenCv will depend on ofxCv

Something to discuss:

  • ofxCv uses namespaces but nothing in the core is using namespaces yet. i think that's fine and we should probably move to namespaces at some point. What i find strange is the way files are laid out:

libs/ofxCv

has addon source which usually only contains external libraries. i would move the source inside src even if it's

src/ofxCv

or just rename the files so

libs/ofxCv/Calibration.h -> src/ofxCvCalibration.h

ping @kylemcdonald

kylemcdonald and others added 30 commits June 15, 2012 18:35
@kylemcdonald
updated gitignore for suo, minor vs2010 mods
5148c61
@kylemcdonald
forgot to git add
c396e07
@kylemcdonald
flow fixes for vs2010, line ending issues maybe? not sure
c383708
@kylemcdonald
added toOf(Mat, ofImage)
4835dc9
@kylemcdonald
fixed autothreshold call
f1aa29a
@kylemcdonald
Merge branch 'master' of github.com:kylemcdonald/ofxCv
f5482de
@kylemcdonald
updated face tracking from workshop, showing what histogram equalizat…
d2331c7 
…ion looks like
@kylemcdonald
poorly named argument on imitate
32304b0
@kylemcdonald
cross-bitdepth copy() works correctly now, and drawMat has been updat…
1949c04 
…ed as well
@kylemcdonald
added equalizeHist wrapper with support for multichannel images
5c3d029
@kylemcdonald
in-place histogram equalization
0366e89
@noisecapella
updating Makefiles to reference openFrameworks common Makefile
fd472c0
@kylemcdonald
Merge pull request openframeworks#47 from bostonbusmap/master
f96b63a 
Makefile fixes
@kylemcdonald
updated xcode projects to use better relative paths
98631ef
@kylemcdonald
ran update-projects to make copies of updated xcode project
23adb69
@kylemcdonald
constifying more of Tracker, might need to double-check contour examples
230aea6
@kylemcdonald
Merge branch 'master' of github.com:kylemcdonald/ofxCv
1466bb7
@kylemcdonald
added TrackerFollower and Follower classes making it easier to work w…
0d50e51 
…ith persistent objects. contributing towards openframeworks#50.
@kylemcdonald
forgot to remove old project files
bcf2d90
@kylemcdonald
added basic kalman filter demo
0e4b857
@kylemcdonald
added video.mov to the two tracking examples
118ac4b
@kylemcdonald
updated c::b for 0071, and vs 2010 had some changes too
e30d868
@noisecapella
adding return statement to non-void function
e16f7d2
@kylemcdonald
Merge pull request openframeworks#51 from bostonbusmap/master
9f85d1a 
Just a fix for a warning for a lack of return statement
@danoli3
Fixed for LLVM Utilities.h scope bug
cbfa937 
kylemcdonald/ofxCv#52
@danoli3
iOS changes to ofxCv
b430030 
Needed to change glFrustrum to glFrustrumf for iOS.

Commented out section of code in Helpers.cpp as some of the commands
are not supported in iOS OpenGL, More research needed into this, I am
not using this currently so commented out :)
@danoli3
Changes for iOS / OpenGLES
06b18cb 
-Added preprocessor statements to wrap around the problem / solution
code to continue to work correctly with all versions.

-Fixed Tab space in Utilities.h

-Changed comment out of code block in Helpers.cpp to preprocessor with
comment to fix for OpenGLES
@kylemcdonald
Merge pull request openframeworks#53 from danoli3/master
f3859cb 
Fixed the scope of toCv bug for LLVM compiler in Utilities.h
@kylemcdonald
first 0072 compatible project file
5d7d6bf
@kylemcdonald
removed old xcode projects
86bcc3f
bakercp and others added 22 commits October 27, 2015 15:51
@bakercp
Fail faster allocation.
4fb7cd8 
- Fails faster.
- Avoids "[ error ] ofPixels: Format doesn't support channels error" calls on unallocated of ofPixels/ofImage, etc.
@kylemcdonald
Merge pull request openframeworks#169 from bakercp/develop
ccb6cec 
Replace deprecated initGrabber() function with setup().
@kylemcdonald
fixed issue with getIndexFromLabel() closes openframeworks#168
710b2f7
@kylemcdonald
Merge pull request openframeworks#170 from bakercp/develop-cleanest
5687069 
remove errors, fail faster, save nanoseconds.
@bakercp
Replace functions deprecated in 0.9.0.
f8904b5
@kylemcdonald
Merge pull request openframeworks#171 from bakercp/develop
22e7d3d 
Replace functions deprecated in 0.9.0.
swapped cv::Size2d with cv::Size2f
60afb23
Merge branch 'develop' of github.com:kylemcdonald/ofxCv into develop
6316a23
@kylemcdonald
Merge pull request openframeworks#172 from aspeteRakete/develop
e023361 
Develop
@kylemcdonald
remove project files
67afcf0
@kylemcdonald
updated readme
0858a4a
@HalfdanJ
Added addon_config.mk
2ce9a35
@kylemcdonald
Merge pull request openframeworks#173 from HalfdanJ/config
596617f 
Added addon_config.mk
@arturoc
fixes some include issues
bd97be3
@arturoc
don't include ofMain
70d89c0
@arturoc
don't expect std in headers
f2e83c4
@kylemcdonald
Merge pull request openframeworks#180 from arturoc/master
4dba411 
fixes some include issues
@arturoc
moved ofxCv to addons/ofxCv
97cdffe
@arturoc
Merge branch 'ofxcv-merge' into feature-ofxcv
df6b7d7
@arturoc
breaklines
e31b13f
@arturoc
moved addon_config to ofxCv
1f6fbdd
@arturoc
gitignore: add ofxCv
84847ef
@arturoc arturoc added the addon label Feb 19, 2016
@arturoc arturoc added this to the 0.10.0 milestone Feb 19, 2016
@ofZach
Copy link
Contributor

ofZach commented Feb 19, 2016

sweet ! -- another discussion point:

do you think it's worthwhile to move CLD out of ofxCv (cc @kylemcdonald ) ? it has always felt like it should be it's own addon. (I'm not sure if there's anything else like that in ofxCv but that has always felt like it would benefit from being on it's own since it's not really opencv and it's kind of a specific algorithm). I like the idea of core addons being more like "building blocks"

@kylemcdonald
Copy link
Contributor

not sure if there's still interest in this -- but yes, i'd move CLD out of ofxCv if it were to be added to the core.

@bakercp
Copy link
Member

bakercp commented Mar 2, 2017

Is this sync-d with the latest ofxCv master branch (which was overhauled recently for 0.10.0 support?). I can't tell from the commit history ...

@bakercp
Copy link
Member

bakercp commented Mar 2, 2017

Opps, sorry, just realized this was a thread from 2016 that Kyle just woke up :) So, no, it probably isn't sync'd with the latest ofxCv.

@ofZach
Copy link
Contributor

ofZach commented Mar 3, 2017

I'm still supportive of bringing ofxCv into the core and sunsetting ofxOpenCv.....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
addon
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.