Skip to content

Local addons ok, Recursive projects fix, storyboard added to ios #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 2, 2025

Conversation

dimitre
Copy link
Member

@dimitre dimitre commented Nov 26, 2024

I'm now working on this issue #580
I've noticed it is mostly working after @roymacdonald PR,
but it enforces using ./ in the start of the path, like

./addons/ofxMidi
etc

this PR allows addons to be added like

addons/ofxMidi
addons/ofxTetris

and also removes the function cleanName.
This function actually parses a commented out line like #ofxSyphon, removes the comment and add the addon back which contradicts the person original intention.

@dimitre dimitre marked this pull request as ready for review November 27, 2024 00:00
@roymacdonald
Copy link
Contributor

and also removes the function cleanName.
This function actually parses a commented out line like #ofxSyphon, removes the comment and add the addon back which contradicts the person original intention.

The purpose of this is to be able to have extra information of an addon in the form of a comment and not loosing that. For example, there is a very nice "Package Manager" made by @thomasgeissl which relies on this feature, where it encodes as a comment the version or commit of an addon, so you can then have that. I am not sure if I implemented it all but the idea is that you dont remove the comments from the addons.mk file

@dimitre
Copy link
Member Author

dimitre commented Feb 27, 2025

cc: @danoli3 @ofTheo I think this issue about a commented out addon being added should be addressed

@dimitre
Copy link
Member Author

dimitre commented Mar 2, 2025

@danoli3 can you help us checking why macos runner is failing here?

@artificiel
Copy link
Contributor

going over this in the context of #8313

I am new to ProjectGenerator but @dimitre I think you misinterpret the cleanName(): it is not to process commented-out addons like #ofxSyphon but to trim lines with comments like ofxSpyhon # tested as of 14.4, where you want to process the addon as ofxSyphon, but you want to carry the whole line and preserve the associated comment.

@danoli3
Copy link
Member

danoli3 commented Mar 2, 2025

@dimitre I'll figure this out now

@danoli3
Copy link
Member

danoli3 commented Mar 2, 2025

Okay lets fix the clean name thing later just add a command to toggle that on or off passed to PG easy with default being on as before but lets merge this I'll fix the rest keep it moving

@danoli3 danoli3 merged commit e26fae1 into openframeworks:master Mar 2, 2025
2 of 3 checks passed
@dimitre dimitre deleted the v87 branch March 3, 2025 00:41
@dimitre dimitre changed the title Local addons ok Local addons ok, Recursive projects fix, storyboard added to ios Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants