Move Map Generator into OpenFrontIO repo #1829
Closed
+5,425
−709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning Rate limit exceeded@evanpelle has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 43 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (38)
📒 Files selected for processing (47)
WalkthroughAdds a Go-based map generator and CLI to produce map binaries, mini-maps, thumbnails, and manifests from assets. Introduces many new map data files, test maps, and a license/README. Updates package.json with a script. Adjusts several existing manifests (adds/removes/edits entries) and removes two legacy map manifests. Changes
Sequence Diagram(s)sequenceDiagram
participant CLI as CLI (go run .)
participant Main as main.go
participant Loader as loadTerrainMaps
participant Worker as processMap
participant Gen as GenerateMap
participant FS as Filesystem
CLI->>Main: Start
Main->>Loader: loadTerrainMaps(maps)
loop for each map (goroutines)
Loader->>Worker: processMap(name, isTest)
Worker->>FS: Read assets/.../image.png, info.json
Worker->>Gen: GenerateMap(args)
Gen-->>Worker: MapResult (map, mini, thumbnail, counts, sizes)
Worker->>FS: Write map.bin, mini_map.bin, thumbnail.webp
Worker->>FS: Write manifest.json (with map/mini_map metadata)
end
Loader-->>Main: Done or error
Main-->>CLI: Print success or fatal error
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
evanpelle
force-pushed
the
evan-add-map-gen
branch
from
ebd2ea5 to
2471660
Compare
evanpelle
force-pushed
the
evan-add-map-gen
branch
from
2471660 to
31f306c
Compare
evanpelle
force-pushed
the
evan-add-map-gen
branch
from
31f306c to
64008a5
Compare
|
|
github-project-automation
bot
moved this from Triage
to Complete
in OpenFront Release Management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Describe the PR.
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
DISCORD_USERNAME