Skip to content

Commit 8b93728

Browse files
authored
Merge pull request #1 from dermatz/add-a11y
Add A11y attributes to breadcrumbs
2 parents ebf805c + 57da76a commit 8b93728

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

view/frontend/templates/hyva/product/breadcrumbs.phtml

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,15 @@ use Opengento\ProductBreadcrumbs\ViewModel\Product\Breadcrumbs as BreadcrumbsCon
1818
$config = $viewModels->require(BreadcrumbsConfig::class);
1919
$isClientSideRendered = !$config->isServerSideRendered() || $config->isClientSideOverrideAllowed();
2020
?>
21-
<div id="product_breadcrumbs"<?= $isClientSideRendered ? ' x-init="generateProductBreadcrumbsOnProductPage()"' : '' ?>>
21+
<div id="product_breadcrumbs" aria-label="<?= $escaper->escapeHtmlAttr(__('Breadcrumb')) ?>" role="navigation"<?= $isClientSideRendered ? ' x-init="generateProductBreadcrumbsOnProductPage()"' : '' ?>>
2222
<?php if ($config->isServerSideRendered()): ?>
2323
<?= $block->fetchView($block->getTemplateFile('Magento_Theme::html/breadcrumbs.phtml')) ?>
2424
<?php endif; ?>
2525
</div>
2626
<?php if ($isClientSideRendered): ?>
2727
<script>
2828
function generateProductBreadcrumbsOnProductPage() {
29-
<?php $breadcrumbsTemplate = '<div id="product_breadcrumbs">' . $block->fetchView($block->getTemplateFile('Magento_Catalog::product/view/breadcrumbs.phtml')) . '</div>'; ?>
29+
<?php $breadcrumbsTemplate = '<div id="product_breadcrumbs" aria-label="' . $escaper->escapeHtmlAttr(__('Breadcrumb')) . '" role="navigation">' . $block->fetchView($block->getTemplateFile('Magento_Catalog::product/view/breadcrumbs.phtml')) . '</div>'; ?>
3030
hyva.replaceDomElement('#product_breadcrumbs', '<?= $escaper->escapeJs($breadcrumbsTemplate) ?>');
3131
}
3232
</script>

view/frontend/templates/product/breadcrumbs.phtml

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ $config = $block->getData('breadcrumbsConfig');
3838
?>
3939
<?= $breadcrumbs->toHtml() ?>
4040
<?php else: ?>
41-
<div class="breadcrumbs"></div>
41+
<div class="breadcrumbs" aria-label="Breadcrumb" role="navigation"></div>
4242
<?php endif; ?>
4343
<?php if (!$config->isServerSideRendered() || $config->isClientSideOverrideAllowed()): ?>
4444
<?php $widget = $this->helper(Data::class)->jsonDecode($viewModel->getJsonConfigurationHtmlEscaped()); ?>

0 commit comments

Comments
 (0)