-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8364454: ProblemList runtime/cds/DeterministicDump.java on macos for JDK-8363986 #26578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8364454: ProblemList runtime/cds/DeterministicDump.java on macos for JDK-8363986 #26578
Conversation
👋 Welcome back iklam! A progress list of the required criteria for merging this PR into |
@iklam This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 113 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@iklam To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label runtime |
@iklam
|
/label hotspot-runtime |
@iklam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial to me.
Thanks @calvinccheung for the review |
Going to push as commit ad0fd13.
Your commit was automatically rebased without conflicts. |
The fix for JDK-8363986 is in progress but may take some time. ProblemList this test for now to avoid noise in testing.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26578/head:pull/26578
$ git checkout pull/26578
Update a local copy of the PR:
$ git checkout pull/26578
$ git pull https://git.openjdk.org/jdk.git pull/26578/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26578
View PR using the GUI difftool:
$ git pr show -t 26578
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26578.diff
Using Webrev
Link to Webrev Comment