8334238: Enhance AddLShortcutTest jpackage test

[alexeysemenyukoracle]

• Enhance AddLShortcutTest to cover more combinations of shortcut configurations of the main and additional launchers.
• Test shortcuts in the predefined app image.

Additionally, rework launcher verification: move launcher icon and shortcut verification code from AdditionalLauncher into LauncherVerifier. This way launcher verification code is encapsulated in a single class that is applied to the main and additional launchers.

Rework launcher shortcut verification on Windows: Read shortcuts from MSI tables. This allows testing of expected and actual shortcuts without installing the MSI. This refactoring removed duplicated checks of file associations: It was performed for every additional launcher; now it is executed for the main launcher only. File association is bound to the main launcher, there is no point to verify it as many times as the number of launchers.

Implement launching launchers through shortcuts on Linux and Windows. The new AddLShortcutTest.testInvokeShortcuts test uses this new functionality.

Not directly related to the subject of the PR:

• JPackageCommand: Added missing and removed redundant verifyMutable() calls. Converted "jpt-unpacked-folder" option into the member field. Added JPackageCommand.createMutableCopy() complementary to the existing JPackageCommand.createImmutableCopy().
• Refactor TKit.waitForFileCreated() to use classes from the java.time package.
• Added test/jdk/tools/jpackage/clean_test_output.sh Bash script filtering test logs to minimize noise in diffs.

Compared traces of IconTest, AddlauncherTest, and AddLShortcutTest tests with and without this patch to verify no unexpected changes in the coverage.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8334238: Enhance AddLShortcutTest jpackage test (Enhancement - P3)

Reviewers

• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26584/head:pull/26584
$ git checkout pull/26584

Update a local copy of the PR:
$ git checkout pull/26584
$ git pull https://git.openjdk.org/jdk.git pull/26584/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26584

View PR using the GUI difftool:
$ git pr show -t 26584

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26584.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334238: Enhance AddLShortcutTest jpackage test

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full - Incremental (2d31e6a5)
• 04: Full - Incremental (a95677ff)
• 03: Full - Incremental (975a493f)
• 02: Full - Incremental (b5da8074)
• 01: Full - Incremental (2d754ee8)
• 00: Full (8d8e7d8f)

[openjdk]

⚠️ @alexeysemenyukoracle This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[sashamatveev]

Looks good.

[alexeysemenyukoracle]

/integrate

[openjdk]

Going to push as commit 7e484e2.

[openjdk]

@alexeysemenyukoracle Pushed as commit 7e484e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.