8364519: Sort share/classfile includes

[fandreuz]

This PR sorts the includes in hotspot/share/classfile using SortIncludes.java. I'm also adding the directory to TestIncludesAreSorted.

Passes tier1.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8364519: Sort share/classfile includes (Enhancement - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Albert Mingkun Yang (@albertnetymk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26590/head:pull/26590
$ git checkout pull/26590

Update a local copy of the PR:
$ git checkout pull/26590
$ git pull https://git.openjdk.org/jdk.git pull/26590/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26590

View PR using the GUI difftool:
$ git pr show -t 26590

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26590.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fandreuz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fandreuz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364519: Sort share/classfile includes

Reviewed-by: shade, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• ee3665b: 8364187: Make getClassAccessFlagsRaw non-native
• 2ba8a06: 8348868: AArch64: Add backend support for SelectFromTwoVector
• 8ac4a88: 8362237: IllegalArgumentException in the launcher when exception without stack trace is thrown
• ... and 3 more: https://git.openjdk.org/jdk/compare/d80b5c8728a18c74cf427817b4b84052a5404870...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @albertnetymk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@fandreuz The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (3477cbce)
• 00: Full (4629ccf9)

[shipilev]

Looks fine, with a nit.

/reviewers 2

[shipilev]

Take this opportunity to remove the include of oop.hpp, since we are including oop.inline.hpp anyway?

[fandreuz]

Sure, I got a few here: 3477cbc

Could this be a possible improvement of SortIncludes.java?

[shipilev]

Maybe, but it is not exactly the include order issue. We do these clean ups opportunistically, when it is glaringly obvious it is an unnecessary include.

[openjdk]

@shipilev
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[shipilev]

Maybe, but it is not exactly the include order issue. We do these clean ups opportunistically, when it is glaringly obvious it is an unnecessary include.

[fandreuz]

/integrate

[fandreuz]

The test failure does not seem to be related to the changes in this PR

[openjdk]

@fandreuz
Your change (at version 3477cbc) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 3387b31.
Since your change was applied there have been 17 commits pushed to the master branch:

• 8269fdc: 8362067: Remove unnecessary List.contains key from SpringLayout.Constraints.pushConstraint
• 57553ca: 8361298: SwingUtilities/bug4967768.java fails where character P is not underline
• 158e59a: 8364106: Include java.runtime.version in thread dump output
• ... and 14 more: https://git.openjdk.org/jdk/compare/d80b5c8728a18c74cf427817b4b84052a5404870...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @fandreuz Pushed as commit 3387b31.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.