-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8364315: Remove unused xml files from test/jaxp/javax/xml/jaxp/functional/javax/xml/transform/xmlfiles #26596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…onal/javax/xml/transform/xmlfiles
👋 Welcome back ayushrigal! A progress list of the required criteria for merging this PR into |
@ayushrigal This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 131 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jaikiran, @JoeWang-Java) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@ayushrigal The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK to me, but please wait for Joe's @JoeWang-Java review before integrating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ayush, Jaikiran.
/integrate |
@ayushrigal |
/sponsor |
Going to push as commit b8acbc3.
Your commit was automatically rebased without conflicts. |
@msheppar @ayushrigal Pushed as commit b8acbc3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
There are number of unused files in the XML test code base. These are not used in any tests and are not referenced within the code base. They appear to be legacy files. These can be removed.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26596/head:pull/26596
$ git checkout pull/26596
Update a local copy of the PR:
$ git checkout pull/26596
$ git pull https://git.openjdk.org/jdk.git pull/26596/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26596
View PR using the GUI difftool:
$ git pr show -t 26596
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26596.diff
Using Webrev
Link to Webrev Comment