8364514: [asan] runtime/jni/checked/TestCharArrayReleasing.java heap-buffer-overflow

[MBaesken]

When running with ASAN enabled binaries , the test runtime/jni/checked/TestCharArrayReleasing.java fails with a heap-buffer-overflow . This is expected because the test checks API usage errors and this way triggers ASAN.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8364514: [asan] runtime/jni/checked/TestCharArrayReleasing.java heap-buffer-overflow (Bug - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26598/head:pull/26598
$ git checkout pull/26598

Update a local copy of the PR:
$ git checkout pull/26598
$ git pull https://git.openjdk.org/jdk.git pull/26598/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26598

View PR using the GUI difftool:
$ git pr show -t 26598

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26598.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364514: [asan] runtime/jni/checked/TestCharArrayReleasing.java heap-buffer-overflow

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

• febd4b2: 8360515: PROPERFMTARGS should always use size_t template specialization for unit
• c0c7d39: 8364587: Update jpackage internal javadoc
• 6b360ac: 8359756: Bug in RuntimePackageTest.testName test
• ... and 34 more: https://git.openjdk.org/jdk/compare/8ac4a88f3c5ad57824dd192cb3f0af5e71cbceeb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (644b4d10)
• 00: Full (3258a5b3)

[dholmes-ora]

Minor suggestion for the comment.

[MBaesken]

Thanks for the review !

/integrate

[openjdk]

Going to push as commit 67ba8b4.
Since your change was applied there have been 37 commits pushed to the master branch:

• febd4b2: 8360515: PROPERFMTARGS should always use size_t template specialization for unit
• c0c7d39: 8364587: Update jpackage internal javadoc
• 6b360ac: 8359756: Bug in RuntimePackageTest.testName test
• ... and 34 more: https://git.openjdk.org/jdk/compare/8ac4a88f3c5ad57824dd192cb3f0af5e71cbceeb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 67ba8b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.