8364541: Parallel: Support allocation in old generation when heap is almost full

[albertnetymk]

Adding old-gen allocation support in heap-almost-full scenario. This can make tests that cause OOM deliberately more resilient to timeout and help runaway apps to exit/fail faster.

Test: tier1-3

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8364541: Parallel: Support allocation in old generation when heap is almost full (Enhancement - P4)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26599/head:pull/26599
$ git checkout pull/26599

Update a local copy of the PR:
$ git checkout pull/26599
$ git pull https://git.openjdk.org/jdk.git pull/26599/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26599

View PR using the GUI difftool:
$ git pr show -t 26599

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26599.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364541: Parallel: Support allocation in old generation when heap is almost full

Reviewed-by: phh, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 86 new commits pushed to the master branch:

• 10762d4: 8365044: Missing copyright header in Contextual.java
• f28126e: 8365050: Too verbose warning in os::commit_memory_limit() on Windows
• c31f486: 8364365: HKSCS encoder does not properly set the replacement character
• ... and 83 more: https://git.openjdk.org/jdk/compare/2ba8a06f0c0a598a6ca7f74e75bab4208e6fa689...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (60a741b5)

[phohensee]

Good idea. :)

[tschatzl]

Not sure why the condition had to be broken into two if-statements, but seems good.

[albertnetymk]

Not sure why the condition had to be broken into two if-statements, but seems good.

The first (tlab-checking) is for correctness (old-gen can't hold tlab), while the other (size and heap-fullness) is more like heuristics.

Thanks for review.

/integrate

[openjdk]

Going to push as commit fd766b2.
Since your change was applied there have been 89 commits pushed to the master branch:

• 8b5bb01: 8364987: javac fails with an exception when looking for diamond creation
• 1fc0b01: 8361142: Improve custom hooks for makefiles
• 0c39228: 8364767: G1: Remove use of CollectedHeap::_soft_ref_policy
• ... and 86 more: https://git.openjdk.org/jdk/compare/2ba8a06f0c0a598a6ca7f74e75bab4208e6fa689...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit fd766b2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.