8364545: tools/javac/launcher/SourceLauncherTest.java fails frequently

[liach]

SourceLauncherTest is placing arbitrary assumptions on the hotspot compiler. Since this test is running the source launcher in the same JVM, we have to create separate jtreg tests to allow running the test and the in-JVM source launcher with another set of VM flags.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8364545: tools/javac/launcher/SourceLauncherTest.java fails frequently (Bug - P2)

Reviewers

• Christian Stein (@sormuras - Committer)
• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26601/head:pull/26601
$ git checkout pull/26601

Update a local copy of the PR:
$ git checkout pull/26601
$ git pull https://git.openjdk.org/jdk.git pull/26601/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26601

View PR using the GUI difftool:
$ git pr show -t 26601

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26601.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364545: tools/javac/launcher/SourceLauncherTest.java fails frequently

Reviewed-by: cstein, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 819de07: 8363998: Implement Compressed Class Pointers for 32-bit
• f40381e: 8356760: VectorAPI: Optimize VectorMask.fromLong for all-true/all-false cases
• e801e51: 8306324: StopThread results in thread being marked as interrupted, leading to unexpected InterruptedException
• ... and 3 more: https://git.openjdk.org/jdk/compare/ee3665bca026fe53409df8391d49477c64ae23a2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@liach The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[liach]

Testing: Ran the newly split test 100 times in repeat in jtreg

[mlbridge]

Webrevs

• 00: Full (1145bfba)

[liach]

/integrate delegate

Will be unavailable soon. If the fix looks good, other committers may integrate once someone approves.

[openjdk]

@liach Integration of this pull request has been delegated and may be completed by any project committer using the /integrate pull request command.

[RogerRiggs]

/label langtools

[openjdk]

@RogerRiggs
The label langtools is not a valid label.
These labels are valid:

• graal
• serviceability
• hotspot
• hotspot-compiler
• ide-support
• i18n
• shenandoah
• jdk
• javadoc
• security
• hotspot-runtime
• jmx
• build
• nio
• client
• core-libs
• compiler
• net
• hotspot-gc
• hotspot-jfr

[RogerRiggs]

/label compiler

[openjdk]

@RogerRiggs The compiler label was already applied.

[sormuras]

Moving the new test with assumptions on the hotspot compiler into a dedicated unit makes sense.

[jaikiran]

In context of the current failure reported in https://bugs.openjdk.org/browse/JDK-8364545, this change looks OK to me.

[liach]

Thanks Jaikiran for this approval. Let's integrate this to stop the spam in CI pipelines.

/integrate

[openjdk]

Going to push as commit 1a206d2.
Since your change was applied there have been 7 commits pushed to the master branch:

• a5e0c9d: 8363720: Follow up to JDK-8360411 with post review comments
• 819de07: 8363998: Implement Compressed Class Pointers for 32-bit
• f40381e: 8356760: VectorAPI: Optimize VectorMask.fromLong for all-true/all-false cases
• ... and 4 more: https://git.openjdk.org/jdk/compare/ee3665bca026fe53409df8391d49477c64ae23a2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@liach Pushed as commit 1a206d2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.