-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8364564: Shortcut configuration is not recorded in .jpackage.xml file #26604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8364564: Shortcut configuration is not recorded in .jpackage.xml file #26604
Conversation
…ageFile: support additional launchers.
…I bundles. With this patch, there is no longer a need to install an MSI package to verify shortcuts.
… verify the contents of an icon file or just verify the icon file's availability.
…nShortcutVerifier class
…: follow-up for function renames in the AdditionalLauncher.
…ditionalLauncher. Introduce LauncherShortcut, LauncherVerifier, LauncherVerifier verifies attributes of any launcher - the main or additional. Add JPackageCommand.createMutableCopy(), hide the copy ctor.
…installed in the system folder on package install and uninstalled on package uninstall. Always verify contents of .desktop files.
…Output` Java property to redirect output
…reamline verifyDesktopFile()
…auncherShortcuts()
…ations of startup directory in the main launcher and in the additional launcher; add testInvokeShortcuts() to invoke launchers through shortcuts and verify work directory; cover shortcuts in the predefined app image
…ithout JDK-8308349 mods
…ent list as it interferes with extracting arguments with optional values.
…corded in .jpackage.xml file
…ed(). Make it public.
5f8fa38
to
7ca2e94
Compare
|
@sashamatveev PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
/integrate |
Going to push as commit 8ad1fcc.
Your commit was automatically rebased without conflicts. |
@alexeysemenyukoracle Pushed as commit 8ad1fcc. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
LauncherShortcut
andLauncherShortcutStartupDirectory
types to the model to define launcher shortcuts. For nowLauncherShortcutStartupDirectory
enum has a single value. It will be extended in JDK-8308349 enhancement.WinLauncherMixin.shortcuts()
withWinLauncherMixin.startMenuShortcut()
andWinLauncherMixin.desktopShortcut()
.StandardBundlerParam.SHORTCUT_HINT
andStandardBundlerParam.MENU_HINT
; use "win-shortcut", "win-menu", and "linux-shortcut" values instead of "shortcut" and "menu" to store launcher shortcut configuration in the ".jpackage.xml" file.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26604/head:pull/26604
$ git checkout pull/26604
Update a local copy of the PR:
$ git checkout pull/26604
$ git pull https://git.openjdk.org/jdk.git pull/26604/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26604
View PR using the GUI difftool:
$ git pr show -t 26604
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26604.diff
Using Webrev
Link to Webrev Comment