8362087: Test containers/docker/ShareTmpDir.java intermittent fails #26605
+16
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
The test containers/docker/ShareTmpDir.java intermittent fails, because before this PR, test assume start two java process in docker container by two threads will make the two java process start simultancely, but in fact, the second java process maybe start slower than the first one, even that the first java process already exit and then the second java process not start yet. If we add
Thread.sleep(2000)
to the second thread at the begin of run() method, will make this intermittent failure to always reproduceable. This prove the anasyis.If the two java process can not start simultancely, the expected '/tmp/hsperfdata_1 locked' error can not observed. So this test will intermittent fails.
This PR will check all the two java processes started already and runing simultancely before exit, this will make the expected '/tmp/hsperfdata_1 locked' error can be alway observed.
The touch file test/hotspot/jtreg/containers/docker/WaitForFlagFile.java only use for test containers/docker/ShareTmpDir.java.
Change has been verified locally, test-fix only, no risk.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26605/head:pull/26605
$ git checkout pull/26605
Update a local copy of the PR:
$ git checkout pull/26605
$ git pull https://git.openjdk.org/jdk.git pull/26605/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26605
View PR using the GUI difftool:
$ git pr show -t 26605
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26605.diff
Using Webrev
Link to Webrev Comment