8360304: Redundant condition in LibraryCallKit::inline_vector_nary_operation

[fandreuz]

The check for sopc != 0 is not needed after JDK-8353786, the function would exit at L374 otherwise.

Passes tier1.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8360304: Redundant condition in LibraryCallKit::inline_vector_nary_operation (Enhancement - P3)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26606/head:pull/26606
$ git checkout pull/26606

Update a local copy of the PR:
$ git checkout pull/26606
$ git pull https://git.openjdk.org/jdk.git pull/26606/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26606

View PR using the GUI difftool:
$ git pr show -t 26606

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26606.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fandreuz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fandreuz This change is no longer ready for integration - check the PR body for details.

[openjdk]

@fandreuz The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (86366e18)

[shipilev]

Looks fine, but I think you want to run vector tests to be extra sure.

jdk/test/jdk/TEST.groups

Lines 402 to 403 in 83953c4

	jdk_vector = \
	jdk/incubator/vector

[fandreuz]

Looks fine, but I think you want to run vector tests to be extra sure.

jdk/test/jdk/TEST.groups

Lines 402 to 403 in 83953c4

	jdk_vector = \
	jdk/incubator/vector

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR  SKIP
   jtreg:test/jdk:jdk_vector                            83    81     0     0     2
==============================
TEST SUCCESS

[shipilev]

This looks good to me.

@iwanowww: from the code history, it looks like you added the check we are now depending on, could you please take a look as well? Thanks!

/reviewers 2

[openjdk]

@shipilev
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).