8343855: HTTP/2 ConnectionWindowUpdateSender may miss some unprocessed DataFrames from closed streams

[GoeLin]

I backport this for parity with 17.0.17-oracle.
Also, it is a follow-up to JDK-8342075: HttpClient: improve HTTP/2 flow control checks.

It needed resolves and adaptions:

Resolved the first chunk in Stream.java which adds the declaration of inputQLock.
The declaraions in the context have been modified by
8308310: HttpClient: Avoid logging or locking from within synchronized blocks.
Omitted one chunk fixing white space.
See first commit.

Adaptions can be found in the second commit.

The change uses locks from 8308310 and introduces a new lock.
To make this work further adaptions are needed (see extra commit):
I add edimports required by the new lock inputQLock.

stateLock is used by this change, but only introduced by JDK-8308310.
Where 21 uses stateLock, the implementation in 17 locks
itself ("this"). I changed the use of stateLock introduced
by this change in pushDateaFrame() accordingly.

Actually, 17 declares a row of methods as synchronized
that are not handled by stateLock in 21, e.g. isCanceled().
So there is a difference in behavior wrt. this lock
between 17 and 21.

I needed to fix two build issues in StreamFlowControlTest.java:

.../test/jdk/java/net/httpclient/http2/StreamFlowControlTest.java:299: error: incompatible types: try-with-resources not applicable to variable type
try (var client = HttpClient.newBuilder().sslContext(sslContext).build()) {
^
(HttpClient cannot be converted to AutoCloseable)

/.../test/jdk/java/net/httpclient/http2/StreamFlowControlTest.java:300: error: cannot find symbol
var request = HttpRequest.newBuilder(URI.create(h2Head)).HEAD().build();
^
symbol: method HEAD()
location: interface Builder

The first I resolved similar to other places in this test in the backport that
brought the test to 17: 073bb3d
Thanks to Aleksey for this detail.

For the second issue I replaced HEAD() by it's implementation.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8343855 needs maintainer approval

Issue

• JDK-8343855: HTTP/2 ConnectionWindowUpdateSender may miss some unprocessed DataFrames from closed streams (Bug - P3 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)
• Ralf Schmelter (@schmelter-sap - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3852/head:pull/3852
$ git checkout pull/3852

Update a local copy of the PR:
$ git checkout pull/3852
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3852/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3852

View PR using the GUI difftool:
$ git pr show -t 3852

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3852.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343855: HTTP/2 ConnectionWindowUpdateSender may miss some unprocessed DataFrames from closed streams

Reviewed-by: phh, rschmelter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 56e1f4b: 8352860: Open source events tests batch0
• c8d4778: 8353126: Open source events tests batch1
• 56759b9: 8341370: Test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails intermittently on macOS-aarch64

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (b02a3482)
• 01: Full - Incremental (8455fa8f)
• 00: Full (b159927c)

[openjdk]

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[schmelter-sap]

Looks good.

[GoeLin]

Thanks for the reviews!

[GoeLin]

/integrate

[openjdk]

Going to push as commit 9b71cd6.
Since your change was applied there have been 3 commits pushed to the master branch:

• 56e1f4b: 8352860: Open source events tests batch0
• c8d4778: 8353126: Open source events tests batch1
• 56759b9: 8341370: Test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails intermittently on macOS-aarch64

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 9b71cd6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.