-
Notifications
You must be signed in to change notification settings - Fork 228
8353304: Open source two JTabbedPane tests #3856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
@satyenme This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request for backport of JDK-8353304: Open source two JTabbedPane tests Motivation: With this change, we provide additional test coverage without changing any functionality (so minimal risk). Change will bring openjdk closer to matching oracle. Risk: Low. Ran GHA Sanity Checks, local Tier 1 and 2 and new manual tests. Patch is nearly clean - spacing difference with |
/integrate |
Going to push as commit eb4dbcf.
Your commit was automatically rebased without conflicts. |
Backporting JDK-8353304: Open source two JTabbedPane tests. Adds two JTabbedPane tests that are now opensourced by oracle. Ran GHA Sanity Checks, local Tier 1 and 2, and new tests directly. Patch is (nearly) clean - spacing issue with
ProblemList.txt
. Backporting for parity with Oracle.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3856/head:pull/3856
$ git checkout pull/3856
Update a local copy of the PR:
$ git checkout pull/3856
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3856/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3856
View PR using the GUI difftool:
$ git pr show -t 3856
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3856.diff
Using Webrev
Link to Webrev Comment