-
Notifications
You must be signed in to change notification settings - Fork 228
8355370: Include server name in HTTP test server thread names to improve diagnostics #3861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
a768de5
to
3e096b4
Compare
@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout goetz_backport_8355370
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I backport this for parity with 17.0.17-oracle.
Removed some OpenJDK 21 functionality.
Test using this pass.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3861/head:pull/3861
$ git checkout pull/3861
Update a local copy of the PR:
$ git checkout pull/3861
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3861/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3861
View PR using the GUI difftool:
$ git pr show -t 3861
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3861.diff
Using Webrev
Link to Webrev Comment