Skip to content

Conversation

galderz
Copy link
Contributor

@galderz galderz commented Jul 8, 2025

This is the second in a series of PRs that I will be sending over the next few days, which make extending JMH to benchmark Java code running as GraalVM native images more easily. The codename for this extension is Fibula. It can still work without this PRs but without them the extension has to duplicate code that exists in JMH, which is not desirable.

This PR enables BenchmarkParams construction to be overriden, in order to easily support JMH use case for benchmarking native images. The JIRA contains a detailed explanation. Having this PR in simplifies construction of BenchmarkParams instance. The changes galderz/fibula@8fd8cf3#diff-601b6d98eff18db8a804efb415d515c3d397d42b9c982713b72c37bea2ebbf18 demonstrate the simplification enabled by the changes here.

Here is the PR list for reference:

  1. Make OutputFormatAdapter public
  2. Enable BenchmarkParams construction to be overriden
  3. Enable alternative Runner instantiation and Main reuse
  4. Enable profiler classes to be reused outside of JMH
  5. Enable JMH integration tests to be executed against other impls

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • CODETOOLS-7904058: Enable BenchmarkParams construction to be overriden (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/160/head:pull/160
$ git checkout pull/160

Update a local copy of the PR:
$ git checkout pull/160
$ git pull https://git.openjdk.org/jmh.git pull/160/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 160

View PR using the GUI difftool:
$ git pr show -t 160

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/160.diff

Using Webrev

Link to Webrev Comment

* It enables Fibula to construct BenchmarkParams instances
with some custom field values that are required for native mode.
* Some reflection might still needed to adjust fields.
E.g with PGO where the executable to instrument,
and the optimized executable are located in different paths.
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2025

👋 Welcome back galder! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 8, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 8, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 5, 2025

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz
Copy link
Contributor Author

galderz commented Aug 6, 2025

/touch

@openjdk
Copy link

openjdk bot commented Aug 6, 2025

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 3, 2025

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz
Copy link
Contributor Author

galderz commented Sep 4, 2025

/touch

@openjdk
Copy link

openjdk bot commented Sep 4, 2025

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@galderz
Copy link
Contributor Author

galderz commented Sep 4, 2025

/touch

@openjdk
Copy link

openjdk bot commented Sep 4, 2025

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2025

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz
Copy link
Contributor Author

galderz commented Oct 9, 2025

/touch

@openjdk
Copy link

openjdk bot commented Oct 9, 2025

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant