RESTWS-945: Orders should allow sorting by date #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g order by dateCreated
makombe
reviewed
Apr 6, 2025
| orders.sort(new Comparator<Order>() { | ||
| @Override | ||
| public int compare(Order o1, Order o2) { | ||
| return o2.getDateCreated().compareTo(o1.getDateCreated()); |
There was a problem hiding this comment.
Should we consider dateActivated or dateCreated?
There was a problem hiding this comment.
Yes now that you mention it I think it is better as well, but in the time I interacted with the issue I didn't see the difference, can you give me examples why is it better?
There was a problem hiding this comment.
Yes now that you mention it I think it is better as well, but in the time I interacted with the issue I didn't see the difference, can you give me examples why is it better?
There will be differences especially where we do RDE for orders
There was a problem hiding this comment.
Okay I will change the code to sort by dateActivated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Comparatorthat sorts bydateCreatedin descending orderIssue I worked on
https://openmrs.atlassian.net/browse/RESTWS-945
Checklist: I completed these to help reviewers :)
[
x] My IDE is configured to follow the code style of this project.[
x] I have added tests to cover my changes. (If you refactoredexisting code that was well tested you do not have to add tests)
[
x] I ranmvn clean packageright before creating this pull request andadded all formatting changes to my commit.
[
x] All new and existing tests passed.[
x] My pull request is based on the latest changes of the master branch.