fix: createAssets fails in case of broken JSON in fetch cache #963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ff07456 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
khuezy
reviewed
Aug 27, 2025
conico974
reviewed
Aug 27, 2025
khuezy
reviewed
Aug 28, 2025
khuezy
approved these changes
Aug 28, 2025
conico974
requested changes
Aug 28, 2025
| const cacheJson = files.json | ||
| ? safeParseJsonFile(fs.readFileSync(files.json, "utf8"), cacheFilePath) | ||
| : undefined; | ||
| if (!cacheFileMeta || !cacheJson) { |
There was a problem hiding this comment.
That is not correct meta does not exist for page router, doing that means that we are skipping any entry from page router.
You should do something like if ((files.meta && !cacheFileMeta) || (files.json && !cacheJson))
There was a problem hiding this comment.
Thanks @conico974, I confirm issue originated in App Router app and was tested only there. I've applied requested fix, please rereview.
conico974
approved these changes
Aug 30, 2025
commit: |
|
@grabmateusz Could you fix linting please. I'll merge once done |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MR closes #961