add(dev-overrides): In memory tagCache with nextMode #964
Conversation
🦋 Changeset detectedLatest commit: e0bc614 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
|
Thanks for the review Kheuzy! |
| export default { | ||
| name: "fs-dev-nextMode", | ||
| mode: "nextMode", | ||
| getLastRevalidated: async (tagsToCheck: string[]) => { |
There was a problem hiding this comment.
I'm not familiar w/ the base spec for tag cache. I see writeTags, shouldn't there be a readTags?
There was a problem hiding this comment.
This is for the new tagCache mode called nextMode. It works a bit different, and also is necessary to make composable cache work when that becomes stable.
hasBeenRevalidated() will check if any tags have been revalidated. You can see it in action here:
opennextjs-aws/packages/open-next/src/utils/cache.ts
Lines 25 to 27 in 31c3740
There was a problem hiding this comment.
Which part of the code reads and load the tags that was written to the file system?
There was a problem hiding this comment.
https://github.com/opennextjs/opennextjs-aws/blob/31c3740/packages/open-next/src/build/createAssets.ts#L253-L269 - the dynamodb-cache.json gets written here during build. In our fs-dev-nextMode override we read that file on top level and put it in a let tags = ....
There was a problem hiding this comment.
Composable cache works with the original tag cache as well. And you don't need the original file
| export default { | ||
| name: "fs-dev-nextMode", | ||
| mode: "nextMode", | ||
| getLastRevalidated: async (tagsToCheck: string[]) => { |
There was a problem hiding this comment.
Composable cache works with the original tag cache as well. And you don't need the original file
|
Thanks Nico! Was a much better idea to use a Map. This |
This is for #958. Our goal is to make E2E work locally
With this new override
revalidateTagandrevalidatePathwill work out of the box running OpenNext locally. This override can be used to support composable caching when that becomes stable aswell. There will come more PRs to make E2E work locally.