ChopIfTooLong for methodInvocation chains #6112
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| package org.openrewrite.java.format; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
| import org.openrewrite.java.JavaParser; | ||
| import org.openrewrite.test.RecipeSpec; | ||
| import org.openrewrite.test.RewriteTest; | ||
|
|
||
| import static org.openrewrite.java.Assertions.java; | ||
| import static org.openrewrite.test.RewriteTest.toRecipe; | ||
|
|
||
| class MinimumViableSpacingVisitorTest implements RewriteTest { | ||
|
|
||
| @Override | ||
| public void defaults(RecipeSpec spec) { | ||
| spec | ||
| .parser(JavaParser.fromJavaVersion().dependsOn(""" | ||
| package com.example; | ||
|
|
||
| public class MyObject { | ||
| public static Builder builder() { return new Builder(); } | ||
| public static Builder newBuilder() { return new Builder(); } | ||
| public static class Builder { | ||
| Builder name(String n) { return this; } | ||
| Builder age(int a) { return this; } | ||
| Builder items(java.util.List<String> items) { return this; } | ||
| Builder nested(MyObject nested) { return this; } | ||
| MyObject build() { return new MyObject(); } | ||
| } | ||
| } | ||
| """)) | ||
| .recipe(toRecipe(() -> new MinimumViableSpacingVisitor<>(null))); | ||
| } | ||
|
|
||
| @Test | ||
| void reformatChainedMethodInvocationToSingleLine() { | ||
| rewriteRun( | ||
| java( | ||
| """ | ||
| package com.example; | ||
| class Test { | ||
| void test() { | ||
| MyObject myObject = MyObject.builder() | ||
| . | ||
|
|
||
| name("John"); | ||
| } | ||
| } | ||
| """, | ||
| """ | ||
| package com.example; | ||
| class Test { | ||
| void test() { | ||
| MyObject myObject = MyObject.builder() | ||
| .name("John"); | ||
| } | ||
| } | ||
| """ | ||
| ) | ||
| ); | ||
| } | ||
|
|
||
| @Test | ||
| void doNotReformatChainedMethodInvocationToSingleLineWhenCommentInPrefixOfName() { | ||
| rewriteRun( | ||
| java( | ||
| """ | ||
| package com.example; | ||
| class Test { | ||
| void test() { | ||
| MyObject myObject = MyObject.builder() | ||
| . //Some comment | ||
| name("John"); | ||
| } | ||
| } | ||
| """ | ||
| ) | ||
| ); | ||
| } | ||
| } | ||
jkschneider marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A method invocation meeting this condition could be contained within another method invocation which meets this condition. In that circumstance the inner method would not be reformatted as no traversal into sub-elements happens when this condition is matched.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, thanks!