-
Notifications
You must be signed in to change notification settings - Fork 466
Added more toml recipes to handle tables #6142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jenson3210
wants to merge
20
commits into
main
Choose a base branch
from
add-toml-table-recipes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenson3210
commented
Oct 16, 2025
rewrite-toml/src/main/java/org/openrewrite/toml/DeleteTableRow.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Oct 16, 2025
rewrite-toml/src/main/java/org/openrewrite/toml/ChangeTableRowValue.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Oct 16, 2025
rewrite-toml/src/main/java/org/openrewrite/toml/ChangeTableRowValue.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Oct 17, 2025
rewrite-toml/src/main/java/org/openrewrite/toml/ReplaceTableRow.java
Outdated
Show resolved
Hide resolved
timtebeek
approved these changes
Oct 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Approved already, but it looks like we could remove some of those explicit validation methods still, as I think we validate that when assigning values to option annotated fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added TOML table row manipulation recipes to enable programmatic modification of TOML array tables, with support for matching, merging, replacing, and deleting rows.
New Recipes
ChangeTableRowValue
- Change a specific property value in a matching table rowDeleteTableRow
- Delete table rows matching specified criteria with regex supportMergeTableRow
- Merge key-value pairs into existing rows or insert new ones, with null value support for removal of keysReplaceTableRow
- Replace entire table rows with other rowsUtilities
TableRowMatcher
- Shared utilities for matching and extracting values from table rows with regex supportSemanticallyEqual
- Recursive equality checking for TOML elements that ignores whitespace and formatting