Add dark mode theme #148
Merged
Add dark mode theme #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-paul
requested changes
Mar 9, 2025
Member
t-paul
left a comment
t-paul
left a comment
There was a problem hiding this comment.
Looks nice. I'm personally not a huge fan of dark mode, but this seems to work quite well. I guess moving forward we need to consider the switch when adding new images.
One issue remains: The icons e.g. on the bottom of the home page or on top of the documentation page are almost invisible. I believe those are all font-awesome glyphs, so I hope it's easy to tag them with a class that is switching colors too.
Contributor
Author
|
I think some of the icons where using transparency to differentiate themselves. I'll take a look and push the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a dark mode theme and the required code infrastructure for switching themes.
The theme is my best interpretation of a dark mode version of the current theme (only changes colours).
The change includes a switcher widget at the top of the page to select between
OS Default,LightandDarkmodes.The display mode is persisted (in local storage) between loads, with the default mode based on your current operation system (or browser) theme.
Theming is utilising the light_dark function.