-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Clone index input in multipart upload flow #19072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clone index input in multipart upload flow #19072
Conversation
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
❌ Gradle check result for ee8717d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
❌ Gradle check result for cf27be8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
❌ Gradle check result for 18138d7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java
Show resolved
Hide resolved
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
❌ Gradle check result for 0464761: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19072 +/- ##
============================================
- Coverage 73.02% 72.94% -0.09%
+ Complexity 69548 69418 -130
============================================
Files 5647 5647
Lines 319106 319119 +13
Branches 46163 46164 +1
============================================
- Hits 233034 232769 -265
- Misses 67232 67492 +260
- Partials 18840 18858 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
❌ Gradle check result for b1069f8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
❌ Gradle check result for c4cf7f4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Test failures seems flaky. Re-triggered the build. |
❕ Gradle check result for c4cf7f4: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
||
completionListener = ActionListener.runAfter(completionListener, () -> { | ||
try { | ||
indexInput.close(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to add a debug/trace log line for places where the close is happening to check in future if any potential leak happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good and should fix the virtual memory issue that we have seen.
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
Description
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.