Allow Parenthsis #6233
Open
Allow Parenthsis #6233
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Utkarsh Agarwal <126544832+Utkarsh-Aga@users.noreply.github.com>
Utkarsh-Aga
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
san81
reviewed
Nov 3, 2025
| private final Set<EventKeyFactory.EventAction> supportedActions; | ||
| private static final Pattern INVALID_KEY_CHARS_PATTERN = | ||
| Pattern.compile("[^A-Za-z0-9._~@/\\[\\]-]"); | ||
| Pattern.compile("[^A-Za-z0-9._~@/\\[\\]\\(\\)-]"); |
Collaborator
There was a problem hiding this comment.
are we looking to enforce a pair to be present? or just one open or closed parentheses should still be allowed?
Contributor
Author
There was a problem hiding this comment.
Since OpenSearch allows the Key Name to have only one parentheses, so did not have the pair check.
Collaborator
There was a problem hiding this comment.
it could help to add this case to the testing scenarios
san81
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow parenthsis to be used.
Issues Resolved
Resolves #5121
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.