Refactor URLs in includes #9867
Conversation
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
kolchfa-aws
requested review from
Naarcha-AWS,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
| @@ -9,7 +9,7 @@ | |||
| {% if jekyll.environment == "development" %} | |||
| <script src="{{ '/assets/js/version-selector.js' | relative_url }}"></script> | |||
| {% else %} | |||
| <script src="{{ '/docs/latest/assets/js/version-selector.js' }}"></script> | |||
| <script src="{{site.baseurl}}/assets/js/version-selector.js"></script> | |||
There was a problem hiding this comment.
Seems like we are replacing hardcode /docs/latest in version selector with {{site.baseurl}}. But this doesn't change the path or routing from before.
Are we plan to update the baseurl in the future so eventually the URL pattern would be docs.opensearch.org/latest/...
There was a problem hiding this comment.
Yes, we're just extracting the path into a variable so when we change the url, we can change only the variable in the _config.yml file (and whatever links are hardcoded in the yaml files).
|
You may need to rebase to resolve the conflict. |
Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> (cherry picked from commit e45b796) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This PR:
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.