Bumping up Faiss to have reusing memory optimization. #110
+24
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ctopus13prime
requested review from
Rajrahane,
navneet1v,
yigithub,
vamshin,
jed326,
rchitale7,
owenhalpert and
neetikasinghal
as code owners
|
This should be merged after #109 |
|
This should be included as well, will rebase to main. |
Bump up Faiss from 2929bf4 to f9ccd58. Signed-off-by: Dooyong Kim <kdooyong@amazon.com>
0ctopus13prime
force-pushed
the
reuse-mem-opt-faiss
branch
from
4351de3 to
dca4627
Compare
jed326
approved these changes
Aug 12, 2025
rchitale7
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumping up Faiss version to have the reusing memory during index conversion optimization.
Without this, byte index conversion will use twice bigger memory.
facebookresearch/faiss#4477
Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.