Skip to content

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Jan 15, 2025

Initial quickstart for Network Observability Operator

Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2025
Comment on lines +40 to +46
2.2 If you are not using Loki, click Loki client settings and change **Enable** to **False**. The setting is True by default.

2.3 If you are using Loki, set the following specifications:

i. **spec.loki.mode**: Set this to the **LokiStack** mode, which automatically sets URLs, TLS, cluster roles and a cluster role binding, as well as the authToken value. Alternatively, the Manual mode allows more control over configuration of these settings.

ii. **spec.loki.lokistack.name**: Set this to the name of your LokiStack resource. In this documentation, loki is used.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stleerh you mentionned you would like to point out Loki Operator doc. How do you want to handle it here ?

Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few little comments to add bold to GUI items, some spacing adjustments before punctuation, and adding "the" in a couple of places. Looks great! This will be nice to have indeed :)

@jpinsonneau
Copy link
Contributor Author

Just a few little comments to add bold to GUI items, some spacing adjustments before punctuation, and adding "the" in a couple of places. Looks great! This will be nice to have indeed :)

Thank you @skrthomas ! Merged your suggestions 😉

Comment on lines +18 to +19
1. In the OpenShift Container Platform web console, click **OperatorHub** from the [Operators]{{highlight qs-nav-operators}} → OperatorHub.
2. Choose **Network Observability Operator** from the list of available Operators in the OperatorHub, and click **Install**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to provide a direct link to that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so as you usually need to search for it first 🤔
Also, it may vary depending of your catalogs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But isn't it what lightspeed is doing?
It seems that this link would work: /operatorhub/ns/default?details-item=netobserv-operator-redhat-operators-openshift-marketplace&channel=stable (assuming using the main official catalog)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it works if you remove the channel ?

Else I feel it's not worth. None of the existing quickstarts are doing such.

@jpinsonneau jpinsonneau marked this pull request as ready for review January 24, 2025 09:43
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 24, 2025
@openshift-ci openshift-ci bot requested review from TheRealJon and jhadvig January 24, 2025 09:44
@jhadvig
Copy link
Member

jhadvig commented Feb 17, 2025

@jotak could you please review the PR if its good to go?
Thank you :)

Copy link
Contributor

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 10, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 10, 2025

@jpinsonneau: This pull request references NETOBSERV-2023 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Initial quickstart for Network Observability Operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 66fbbb1 and 2 for PR HEAD e7b4d3f in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 66fbbb1 and 2 for PR HEAD e7b4d3f in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD cd83cd2 and 2 for PR HEAD e7b4d3f in total

@jpinsonneau
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD cd83cd2 and 2 for PR HEAD e7b4d3f in total

Copy link
Contributor

openshift-ci bot commented Apr 11, 2025

@jpinsonneau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit fe800f5 into openshift:main Apr 11, 2025
12 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console-operator
This PR has been included in build openshift-enterprise-console-operator-container-v4.19.0-202504111744.p0.gfe800f5.assembly.stream.el9.
All builds following this will include this PR.

@jpinsonneau
Copy link
Contributor Author

/cherry-pick release-4.18

@openshift-cherrypick-robot

@jpinsonneau: new pull request created: #997

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jpinsonneau
Copy link
Contributor Author

/cherry-pick release-4.17

@openshift-cherrypick-robot

@jpinsonneau: new pull request created: #998

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jpinsonneau
Copy link
Contributor Author

/cherry-pick release-4.16

@jpinsonneau
Copy link
Contributor Author

/cherry-pick release-4.15

@jpinsonneau
Copy link
Contributor Author

/cherry-pick release-4.14

@jpinsonneau
Copy link
Contributor Author

/cherry-pick release-4.12

@openshift-cherrypick-robot

@jpinsonneau: new pull request created: #999

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@jpinsonneau: new pull request created: #1000

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@jpinsonneau: new pull request created: #1001

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@jpinsonneau: new pull request created: #1002

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jhadvig jhadvig changed the title NETOBSERV-2023: Implement a quickstart for netobserv operator OCPBUGS-60303, NETOBSERV-2023: Implement a quickstart for netobserv operator Aug 11, 2025
@openshift-ci-robot
Copy link
Contributor

@jpinsonneau: Jira Issue OCPBUGS-60303 is in an unrecognized state (Closed) and will not be moved to the MODIFIED state.

In response to this:

Initial quickstart for Network Observability Operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants