-
Notifications
You must be signed in to change notification settings - Fork 1.8k
TELCODOCS-2273 - RN - unnumbered BGP Peering - GA #100042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enterprise-4.20
Are you sure you want to change the base?
Conversation
🤖 Wed Oct 08 18:51:00 - Prow CI generated the docs preview: |
/lgtm |
ltgm |
==== Unnumbered BGP peering | ||
|
||
With this release, {product-title} includes unnumbered BGP peering. | ||
This was previosuly available as a Technology Preview feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: previously
|
||
* Simplified permissions: You can now simplify permissions and reduce operational overhead by using namespaced SR-IOV networks. | ||
|
||
For more information, see xref:../networking/hardware_networks/configuring-namespaced-sriov-resources.html#configuring-namespaced-sriov-resources[Configuring namespaced SR-IOV resources]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yours but pretty sure it should be .adoc rather than .html in xref
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is my bad can you fix it when in here sorry @slovern should be extension .adoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the change in #100184 so can ignore
With this release, {product-title} includes unnumbered BGP peering. | ||
This was previosuly available as a Technology Preview feature. | ||
You can use the `spec.interface` field of the BGP peer custom resource to configure unnumbered BGP peering. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add xref: For more information, see xref:../networking/ingress_load_balancing/metallb/metallb-configure-bgp-peers.adoc#nw-metallb-example-unnumbered-bgp-peering_configure-metallb-bgp-peers[Example: Specify BGP peers for unnumbered BGP peering]
a6fc46d
to
4138ca1
Compare
New changes are detected. LGTM label has been removed. |
With this release, {product-title} includes unnumbered BGP peering. | ||
This was previously available as a Technology Preview feature. | ||
You can use the `spec.interface` field of the BGP peer custom resource to configure unnumbered BGP peering. | ||
For more information, see xref:../networking/ingress_load_balancing/metallb/metallb/metallb-frr-k8s.html#nw-metallb-frrconfiguration-crd-interface[The interface field]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.XrefContainsHTML: Use .adoc instead of .html in xrefs
@slovern: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s):4.20
Issue: https://issues.redhat.com/browse/TELCODOCS-2273
Link to docs preview: Unnumbered BGP peering
QE review:
Additional information: