-
Notifications
You must be signed in to change notification settings - Fork 1.8k
CNV-52860: Passt binding for primary UDNs #100075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@sjhala-ccs: This pull request references CNV-52860 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@sjhala-ccs: This pull request references CNV-52860 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@sjhala-ccs: This pull request references CNV-52860 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
55b28d0
to
3bdb83b
Compare
@sjhala-ccs: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will need @nirdothan's review here too, since this doc is quite technical.
:_mod-docs-content-type: PROCEDURE | ||
[id="virt-attaching-vm-to-primary-udn-web_{context}"] | ||
= Attaching a virtual machine to the primary user-defined network by using the web console | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make it clear at the top that by default it just works. That VMs created in a namespace where primary UDN is configured will automatically attach to it using the l2bridge network binding. Maybe that should be the first info in the procedure. And only then the optional switch to passt should follow
Version(s): 4.20+
Issue: CNV-52860
Link to docs preview: https://100075--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-connecting-vm-to-primary-udn.html#attaching-vm-to-primary-udn_virt-connecting-vm-to-primary-udn
QE review:
Additional information: