Update jit_avx512_core_x8s8s32x_conv_kernel.cpp #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmitry-gorokhov @RICKIE777 I have applied the change to the original commit in scope of oneDNN 3.0 migration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete 3D depthwise unimplemented judgments
Description
In oneDNN branch v2.4_for_ie_master, the detail commit is 10fcf5d . In src/cpu/x64/jit_avx512_core_x8s8s32x_conv_kernel.cpp file, delete the 3D depthwise unimplemented judgments. BUT these lines are preserved in the latest version v2.7_for_ie_master.
If these lines are not deleted, some models on the xeon platform will choose to run with a non-avx512 kernel, resulting in performance degradation. Such as JIRA CVS-98185.
PR in OpenVINO: openvinotoolkit/openvino#15632