Base LLM pipeline testing refactoring and optimization #2779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: continuous batching
apaniukov
reviewed
Sep 30, 2025
apaniukov
reviewed
Sep 30, 2025
apaniukov
requested changes
Sep 30, 2025
Yes, in LLM pipeline tests it's done. I'm currently looking on how to make it work properly for LLL static pipeline. |
sgonorov
force-pushed
the
testing_llm_pipeline_speedup
branch
from
8c2c779 to
1f12a03
Compare
sgonorov
force-pushed
the
testing_llm_pipeline_speedup
branch
from
85d9db9 to
1e323b2
Compare
sgonorov
force-pushed
the
testing_llm_pipeline_speedup
branch
from
1e323b2 to
7820744
Compare
github-actions
bot
added
category: LLM samples
sgonorov
force-pushed
the
testing_llm_pipeline_speedup
branch
from
ab9bc74 to
6933c81
Compare
apaniukov
reviewed
Oct 7, 2025
apaniukov
reviewed
Oct 7, 2025
Comment on lines
+210
to
+215
| from pathlib import Path | ||
| media_path = (Path(download_test_content) / media_file).as_posix() |
There was a problem hiding this comment.
Can we make download_test_content to return a Path object? And/or move the import to the top?
There was a problem hiding this comment.
We can do it, but most use-cases for this fixture as a string parameter, so it'll just add more conversions.
apaniukov
reviewed
Oct 7, 2025
sgonorov
force-pushed
the
testing_llm_pipeline_speedup
branch
from
ffd8269 to
c4bfe29
Compare
sgonorov
force-pushed
the
testing_llm_pipeline_speedup
branch
3 times, most recently
from
2d04bc3 to
0a51896
Compare
sgonorov
force-pushed
the
testing_llm_pipeline_speedup
branch
from
0a51896 to
af1ab81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket:
Part of CVS-173285