Handle different json primitives #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8
Fairly simple PR. Tested lightly.
Breaks backwards compatibility for values that match a json primitive. A few examples:
4, what would be a"4"is now44.2, what would be a"4.2"is now4.2null, what would be a"null"is nownulltrue, what would be a"true"is nowtrue"quoted string", what would be a"\"quoted_string\""is now"quoted_string"some other random string, there's no change. The result will stay"some other random string".Personally, I would like to see it merged, since I'm using this package in a project I'm developing and I'm pretty happy with it!
Of course, I can use my fork in the meantime.
Let me know if there's anything else I can do.