Skip to content

Conversation

trick2011
Copy link

Modified all instances that refer to the existing vdev by device to vdev in zpool attach, in order to clarify usage.

Fixes bug report #17734

This commit fixes unclear usage of device when referring to the existing vdev in zpool attach manpage.

Motivation and Context

This fixes open issue #17734

When looking up the parameters to use for zpool attach, the meaning of "device" in the parameter description is unclear/ambiguous. The name "device" refers to a vdev in the pool and as such it is clearer to refer to it as such as the intent, attaching a new device to an existing vdev, is communicated more clearly this way.

Description

How Has This Been Tested?

Opened using man and visually checked

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@github-actions github-actions bot added the Status: Work in Progress Not yet ready for general review label Sep 12, 2025
@behlendorf behlendorf added the Type: Documentation Indicates a requested change to the documentation label Sep 12, 2025
Fixes bug report openzfs#17734

Signed-off-by: trick2011 <trick2011@users.noreply.github.com>
@trick2011 trick2011 marked this pull request as ready for review September 13, 2025 15:11
@github-actions github-actions bot added Status: Code Review Needed Ready for review and testing and removed Status: Work in Progress Not yet ready for general review labels Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Code Review Needed Ready for review and testing Type: Documentation Indicates a requested change to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants