[GR-64675] Introduce TypeFlow.flowState #11966
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges three
TypeFlow
volatile integer fieldsisEnabled
,isSaturated
, andpredicateTriggered
into a singleflowState
field. It saves 8B per flow instance and we allocate millions of flows when building bigger images, so we can expect reduction in terms of tens of MB. Not a groundbreaking improvement, but relatively simple to implement. Apart from footprint reduction, this change also helps to more explicitly capture the possible state transitions each flow may go through.This PR also includes a refactoring that caches
PointstoOptions.TrackAccessChain
andPointstoOptions.ParsingContextMaxDepth
inAnalysisPolicy
, which are currently queried inside everyAnalysisMethod
constructor (andAnalysisField
constructor forTrackAccessChain
).