Add search index #4306
Draft
Add search index #4306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casey
requested changes
Apr 1, 2025
Comment on lines
+76
to
+77
| #[arg(long, help = "Use search index at <SEARCH_INDEX>.")] | ||
| pub(crate) search_index: Option<PathBuf>, |
There was a problem hiding this comment.
I think this doesn't even need to be configurable initially. We could just put it into the ord data dir.
Comment on lines
+289
to
+291
| if search_indexer.join().is_err() { | ||
| log::warn!("Search index thread panicked; join failed"); | ||
| } |
There was a problem hiding this comment.
Just good for debuggability:
Suggested change
| if search_indexer.join().is_err() { | |
| log::warn!("Search index thread panicked; join failed"); | |
| } | |
| if let Err(err) = search_indexer.join() { | |
| log::warn!("Search index thread panicked: {err}"); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.