Skip to content

Conversation

@OverlordQ
Copy link

Should verify that the address conversion is actually right.

@coveralls
Copy link

coveralls commented Aug 5, 2019

Pull Request Test Coverage Report for Build 15

  • 27 of 29 (93.1%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 92.694%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cashaddress/convert.py 27 29 93.1%
Totals Coverage Status
Change from base Build 14: -0.4%
Covered Lines: 203
Relevant Lines: 219

💛 - Coveralls

@ghost
Copy link

ghost commented Aug 5, 2019

Thanks for adding tests with this. With adding SLP, my thought is that it'd be nice to have a separate functions here. Maybe like, validate_slp_address or validate_pkh_address, or something like that.

Otherwise might get a simpletoken address and try to process it while not being able to support it, even though the address itself is technically valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants